Re: [U-Boot] [PATCH v2] zlib: fix code when DEBUG is defined

Dear Giuseppe CONDORELLI,

In message 1251970209-9053-1-git-send-email-giuseppe.condorelli@st.com you wrote:

Removed stdio.h inclusion and moved trace macros to use printf avoiding to write debug informations to standard error.

Signed-off-by: Giuseppe Condorelli giuseppe.condorelli@st.com

lib_generic/zlib.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

old: 1 files changed, 29 insertions(+), 30 deletions(-) new: 1 files changed, 2 insertions(+), 2 deletions(-)

Isn't that great?

@@ -2000,7 +2001,6 @@ void z_error (m) char *m; { fprintf(stderr, "%s\n", m);

• exit(1);

} #endif

Sorry for not catching this in the first round.

What happens when we return here? Obviously this function is supposed to never return. Should we call hang() here?

Best regards,

Wolfgang Denk