Dear Asen Dimov,
Hello Reinhard,
On 06/09/2011 01:57 PM, Reinhard Meyer wrote: ...
Dear Asen Dimov, The empty reset_timer() function added there can obviously only solve build issues. On any account reset_timer() must not be used anymore. As such this patch must get a NAK.
The architectures, except AT91 are using reset_timer() to make epochs (start from zero). I don't want to break the other architectures and I need the CFI driver for pm92613 and pm9261. I can not think of another idea, except an empty reset_timer(). Any suggestions, ideas?
1. an empty reset_timer() will allow you to build, but at runtime it must break.
2._if_ the current CFI driver is based on reset_timer() that should actually be fixed there. Whereby the actual impact on other architectures that have a broken get_timer() implementation and therefore _require_ reset_timer() is unclear to me. We just had a lengthy discussion about timer API etc. In essence, this discussion, whatever exact API will be implemented, resulted in NOT having any reset_timer() and only a monotonous, millisecond returning get_timer() function.
The only _interim_ solution would be to reintroduce the original reset_timer() to AT91, which I am NOT fond of.
Wolfgang?
Best Regards, Reinhard