Hello,
in message 1164593553.28194.2.camel@localhost.localdomain you wrote:
How about the progress of mpc7448hpc2 board in u-boot?
I had a look at your code.
I see a few problems:
1) it does not merge cleanly with the current top of tree in the git repo; there are conflicts with common/cfi_flash.c
2) there are lots of coding style violations: C++ comments in drivers/tsi108_i2c.cand include/configs/mpc7448hpc2.h; trailing white space in board/mpc7448hpc2/asm_init.S, board/mpc7448hpc2/mpc7448hpc2.c, board/mpc7448hpc2/tsi108_init.c, cpu/74xx_7xx/cpu.c, cpu/74xx_7xx/speed.c, doc/README.mpc7448hpc2, drivers/tsi108_i2c.c, include/configs/mpc7448hpc2.h, include/tsi108.h; indentation not by TABs at least in board/mpc7448hpc2/asm_init.S, include/configs/mpc7448hpc2.h; trailing empty lines in doc/README.mpc7448hpc2.
Note that these are just examples; the same problems may be present in other files as well. Please check ALL your code.
Also, you don't place spaces as reqyired by the Coding Style (for example, we normally have spaces before the '(' of a function call).
Also, the Coding Style discourages using '{ ... }' for simple one-line conditionals.
3) Your Makefiles don't support building in a separate directory
4) Indentation looks not nice. For example, in board/mpc7448hpc2/asm_init.S we have:
+ mfspr r3,1014 /* read MSSCR0 */ + rlwinm. r3,r3,27,31,31 /* get processor ID number */ + mtspr SPRN_PIR,r3 /* Save CPU ID */ + sync + bne init_done + b do_tsi108_init
This is not indented by TAB's, and why don;t you align the arguments of the "bne" and "b" instructions like the rest?
Or take this:
+#define READ_SPD(byte_num) \ + addis r3, 0, byte_num@l;\ + or r3, r3, r10;\ + ori r3, r3, 0x0A;\ + stw r3, SD_I2C_CTRL1(r4);\ + li r3, I2C_CNTRL2_START;\ + stw r3, SD_I2C_CTRL2(r4);\ + eieio;\ + sync;\ + li r3, 0x100;\
Or this:
+ READ_SPD(12) /* get Refresh Rate */ + beq check_next_slot + li r5, ERR_RFRSH_RATE + cmpi 0,0,r3,SPD_MIN_RFRSH + ble spd_fail + cmpi 0,0,r3,SPD_MAX_RFRSH + bgt spd_fail + addi r3,r3,-SPD_MIN_RFRSH + rlwinm r3,r3,2,0,31 + lis r5,refresh_rates@h + ori r5,r5,refresh_rates@l + lwzx r5,r5,r3 /* get refresh rate in nSec */ + divwu r5,r5,r9 /* calculate # of SDC clocks */ + stw r5,SD_REFRESH(r4) /* Set refresh rate */
Sorry, but I consider this unreadable.
5) board/mpc7448hpc2/mpc7448hpc2.c contains yet another memory test. Do we really need another copy of this code?
6) Some files - like mpc7448hpc2/tsi108_init.c - contain deep magic with little or no comments (see for example function board_early_init_f()). I guess you want to add some more comments here and there...
7) The output of your code seems to be pretty different from what we have on other boards; see again board_early_init_f():
+ printf("BUS! %d MHz\n", get_board_bus_clk() / 1000000); + printf("MEM! %d MHz\n", gd->mem_clk / 1000000);
Can you please try keeping the look and feel we have on most other boards?
8) Your code adds some data structures globally (like hid1_7447A_multipliers_x_10[] in cpu/74xx_7xx/speed.c) which are probably not needed for all processors. Maybe you can use some #ifdef's here to prevent adding lots of dead code / data to most board configurations?
9) The login here looks weird to me - is this correct? cpu/74xx_7xx/speed.c: ... +#ifdef CFG_CONFIG_BUS_CLK + gd->bus_clk = get_board_bus_clk(); +#else + gd->bus_clk = CFG_BUS_CLK; +#endif
10) Please keep your line length within the allowed limits.
11) Please don't define CONFIG_ETHADDR / CONFIG_ETH1ADDR in your board config file. It is really evil when all boards have the same MAC addresses. Also, are the addresses you used officially assigned ones?
Same is for CONFIG_IPADDR, CONFIG_SERVERIP, CONFIG_NETMASK, CONFIG_GATEWAYIP - it may save some time to have these set during development, but for a public source version I don't ever want to see these.
12) In lib_ppc/extable.c you add code with a "#ifdef CFG_EXCEPTION_AFTER_RELOCATE; there is absolutely no explanation nor comment anywhere why you think this is necessary.
Please clean up and resubmit.
Best regards,
Wolfgang Denk