Re: [U-Boot] [PATCH 5/7] Add mdio command for new PHY infrastructure

On Mar 30, 2011, at 6:55 AM, Detlev Zundel wrote:

Hi Andy,

...

+static int extract_range(char *input, int *plo, int *phi) +{

• char * end;
• *plo = simple_strtol(input, &end, 0);
• if (end == input)

• return -1;
  

• if (*end == '-') {

What about the case of input="12-"? Shouldn't there be an "&& *(end+1)"?

Ok. It should be noted that cmd_mii.c has the same issue.

I'm about to send out the v2.

Andy