On 21.08.2014 10:53, Thomas Chou wrote:
This patch implements the generic board init as described in doc/README.generic-board.
Good idea. Please find below a few comments, mostly coding style related.
<snip>
diff --git a/arch/nios2/cpu/cpu.c b/arch/nios2/cpu/cpu.c index e0dcbc2..4714171 100644 --- a/arch/nios2/cpu/cpu.c +++ b/arch/nios2/cpu/cpu.c @@ -10,11 +10,13 @@ #include <nios2-io.h> #include <asm/cache.h>
+DECLARE_GLOBAL_DATA_PTR;
- #if defined (CONFIG_SYS_NIOS_SYSID_BASE) extern void display_sysid (void); #endif /* CONFIG_SYS_NIOS_SYSID_BASE */
-int checkcpu (void) +int print_cpuinfo (void)
While changing this line, please fix the coding style to:
+int print_cpuinfo(void)
No space before the "(".
<snip>
diff --git a/common/board_f.c b/common/board_f.c index d5e7622..77a1990 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -9,7 +9,6 @@
- SPDX-License-Identifier: GPL-2.0+
*/
- #include <common.h>
This empty line removal seems to have slipped in. I know, its nitpicking, but I would prefer to not change unrelated things.
Otherwise looks good:
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan