Re: [U-Boot] [PATCH v2] NAND: Add 16bit NAND support for the NDFC

...

+#ifdef CONFIG_SYS_NDFC_16BIT /* Shift the offset from byte addressing to word addressing. */

• if (this->options & NAND_BUSWIDTH_16)

• offs >>= 1;
  

• offs >>= 1;

+#endif

This is not an NDFC-specific file.

Oh, yeah, I see. This should not have been swapped to a preprocessor condition. Could we make a general define for 16 bit NAND not just limited to the NDFC? Or would you rather just have the extra if condition despite the extra code space it takes up?

Regards, Alex