-----Original Message----- From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com] Sent: Wednesday, June 01, 2016 12:07 PM To: Rajesh Bhagat rajesh.bhagat@nxp.com; Marek Vasut marex@denx.de; Rajat Srivastava rajat.srivastava@nxp.com; u-boot@lists.denx.de Cc: l.majewski@samsung.com; sjg@chromium.org; albert.u.boot@aribaud.net; prabhakar@freescale.com; york sun york.sun@nxp.com; Mingkai Hu mingkai.hu@nxp.com; michal.simek@xilinx.com Subject: RE: [PATCH 2/3] armv8/fsl-layerscape: add dwc3 gadget driver support
Hi,
Rajesh Bhagat rajesh.bhagat@nxp.com writes:
Marek Vasut marex@denx.de writes:
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 85cc96a..5eeb71d 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -690,6 +690,18 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev) return -ENOMEM; }
+#if defined(CONFIG_LS1043A)
How was this added in Linux ? I doubt such horrid ifdef was allowed. I presume it went through either DT or struct dwc3_device, right ? So fix this here the same way.
dwc3 doesn't have any of that. I wouldn't take it :-p
Hello Felipe/Marek,
It is not currently added in Linux, These registers setting is required for Setting the burst beat transactions and enabling the snooping for DWC3
USB IP.
that's fine, but you don't need to ifdef around that. Pass these values from your platform code.
Can it be added using dwc3 uboot glue layer e.g. dwc3-fsl.c ?
keep in core, but pass them from plat code instead of hardcoding under ifdef.
Also, get rid of the magic constant ;-)
Ok, thanks. Will take care in v2.
-- balbi