Hi all
Magnus, are you going to fix the code as proposed by Ben and Guennadi or should I resubmit the patch?
Ultimately, somebody needs to submit a patch. Since Magnus won't try it til later this week, it would be best if you post a patch incorporating changes. Then if it works, we're ready to go.
May I suggest adding something like this to the smc911x.c-patch as well:
#if defined(CONFIG_DRIVER_SMC911X_32_BIT) && defined(CONFIG_DRIVER_SMC911X_16_BIT) #error "SMC911X: Only one of CONFIG_DRIVER_SMC911X_32_BIT and CONFIG_DRIVER_SMC911X_16_BIT shall be set" #endif
(but with the correct line wrapping, the above is written directly in gmail and I don't know how gmail will mangle the code)
Just in case someone accidentally defines both in the config file.
Also, I tested the patch with Ben's modifications and it seems to work on the i.MX31 Litekit board. Tried both ping and tftp file transfer with the 16 bit option (and 32 bit option).
Regards, Magnus