On Wed, Jan 28, 2015 at 1:13 PM, Simon Glass sjg@chromium.org wrote:
Since the FSP is a black box it helps to have some sort of debugging available to check its inputs. If the debug UART is in use, set it up after CAR is available.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Remove duplicate prototype of setup_early_uart()
arch/x86/include/asm/u-boot-x86.h | 3 +++ arch/x86/lib/fsp/fsp_support.c | 4 ++++ 2 files changed, 7 insertions(+)
diff --git a/arch/x86/include/asm/u-boot-x86.h b/arch/x86/include/asm/u-boot-x86.h index b98afa8..5d7dff5 100644 --- a/arch/x86/include/asm/u-boot-x86.h +++ b/arch/x86/include/asm/u-boot-x86.h @@ -45,6 +45,9 @@ ulong board_get_usable_ram_top(ulong total_size); void dram_init_banksize(void); int default_print_cpuinfo(void);
+/* Set up a UART which can be used with printch(), printhex8(), etc. */ +int setup_early_uart(void);
void setup_pcat_compatibility(void);
void isa_unmap_rom(u32 addr); diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index 8b639f7..5f96da1 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -124,6 +124,10 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf) struct fsp_init_params *params_ptr; struct upd_region *fsp_upd;
+#ifdef CONFIG_DEBUG_UART
setup_early_uart();+#endif
fsp_hdr = find_fsp_header(); if (fsp_hdr == NULL) { /* No valid FSP info header was found */--
Reviewed-by: Bin Meng bmeng.cn@gmail.com