Re: [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'

On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson ulfalizer@gmail.com wrote:

'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.

Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which does more strict checking here:

    kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse '        select n': expected nonconstant symbol

Signed-off-by: Ulf Magnusson ulfalizer@gmail.com

board/google/Kconfig | 1 - 1 file changed, 1 deletion(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com