Re: [U-Boot] [PATCH 006/126] dm: core: Correct bad cast in ofnode_get_addr_size_index()

On Wed, Sep 25, 2019 at 10:58 PM Simon Glass sjg@chromium.org wrote:

At present this code passes an fdt_addr_t pointer as a u64 pointer which is not save, since sizeof(fdt_addr_t) may be 4, e.g. with sandbox. Correct

not safe

this to avoid a stack corruption problem.

Fixes: e679d03b08 (core: ofnode: Add ofnode_get_addr_size_index) Signed-off-by: Simon Glass sjg@chromium.org

---

drivers/core/ofnode.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com

I think this should go in v2019.10.

Tom, I will prepare a PR soon.

Regards, Bin