Re: [U-Boot] [PATCH 1/3] common: add possibility for readline_into_buffer timeout

Hello Mike,

Mike Frysinger wrote:

On Sunday 15 January 2012 02:53:40 Heiko Schocher wrote:

...

--- a/common/main.c +++ b/common/main.c

• if ((first) && (timeout)) {
  

those inner parens make no sense

Yep, fixed.

...

• 	ulong start = get_timer(0);
  

• 	ulong delay = timeout * CONFIG_SYS_HZ;
  

what do you want the timeout to be in ? milliseconds ? then make that part

seconds, similiar to bootdelay.

of the API (add comments to the relevant funcs), and drop the CONFIG_SYS_HZ usage.

Fix this (Do it like bootdelay is done, using endticks())

Thanks for the review.

bye, Heiko