On Thu, Sep 10, 2020 at 3:30 PM Tom Rini trini@konsulko.com wrote:
On Tue, Sep 01, 2020 at 07:23:00PM +0200, Robert Marko wrote:
PHY handling functions should depend also on CONFIG_USB_DWC3 aka DM DWC3 version. Otherwise when using the non DM version with PHY subsystem enabled there will be a linking error due to missing dwc3_setup_phy and dwc3_shutdown_phy.
Signed-off-by: Robert Marko robert.marko@sartura.hr Cc: Luka Perkov luka.perkov@sartura.hr
include/dwc3-uboot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dwc3-uboot.h b/include/dwc3-uboot.h index e08530ec4e..5eb0822d74 100644 --- a/include/dwc3-uboot.h +++ b/include/dwc3-uboot.h @@ -47,7 +47,7 @@ void dwc3_uboot_exit(int index); void dwc3_uboot_handle_interrupt(int index);
struct phy; -#if CONFIG_IS_ENABLED(PHY) && CONFIG_IS_ENABLED(DM_USB) +#if CONFIG_IS_ENABLED(PHY) && CONFIG_IS_ENABLED(DM_USB) && CONFIG_IS_ENABLED(CONFIG_USB_DWC3) int dwc3_setup_phy(struct udevice *dev, struct phy_bulk *phys); int dwc3_shutdown_phy(struct udevice *dev, struct phy_bulk *phys); #else
This should be CONFIG_IS_ENABLED(USB_DWC3).
This was dropped in v3 that will be sent out soon. Regards Robert
-- Tom