Hi Kever,
On 11/7/24 8:14 AM, Kever Yang wrote:
Hi Quentin,
On 2024/11/6 19:29, Quentin Schulz wrote:
From: Quentin Schulz quentin.schulz@cherry.de
If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is provided in the TPL Device Tree, this will trigger a system reset similar to what's currently been done in SPL whenever the RK3399 "warm" boots. Because there's currently only one user of sysreset-gpio logic, and TPL is enabled on that board, so let's migrate the logic and that board to do it in TPL.
There are three reasons for moving this earlier:
Yes, this movement is reasonable and needed for this workaround, although still not
understand why puma board need this.
Me neither, this predates me joining the company, c.f.: https://source.denx.de/u-boot/u-boot/-/commit/ae0d33a7291a164a11ae034bcf4f71... https://source.denx.de/u-boot/u-boot/-/commit/5f104178bf713615dc404fdfcf0fb5... https://source.denx.de/u-boot/u-boot/-/commit/07586ee4322abca01db52624b925e5...
What I can tell you is that it seems this is required as Paul (in Cc) is trying to add support for it for the Firefly ROC-RK3399-PC[1] and the ROCKPro64[2], so it seems it's useful for **some** purpose.
[1] https://lore.kernel.org/u-boot/20240926183111.1324284-1-paulk@sys-base.io/ [2] https://lore.kernel.org/u-boot/20240926183111.1324284-2-paulk@sys-base.io/
- faster boot time as we don't need to reach SPL to be able to reset the
system on a condition we know is already met in TPL,
- have less code to be impacted by the issue this system reset works
around (that is, "unclean" SoC registers after a reboot),
- less confusion around the reason for restarting. Indeed when done from
SPL, the following log can be observed:
""" U-Boot TPL 2025.01-rc1-00165-gd79216ca9878-dirty (Nov 05 2024 - 15:31:45) Channel 0: DDR3, 666MHz BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB Channel 1: DDR3, 666MHz BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB 256B stride Trying to boot from BOOTROM Returning to boot ROM...
U-Boot SPL 2025.01-rc1-00165-gd79216ca9878-dirty (Nov 05 2024 - 15:31:45 +0100) Trying to boot from MMC2
U-Boot TPL 2025.01-rc1-00165-gd79216ca9878-dirty (Nov 05 2024 - 15:31:45) """
So with this patch set, we can see the TPL banner twice ?
PS: We are able to merge to master instead of next before next branch is open, because we still have
enough time to debug before next release.
My understanding is that once -rc1 is out, we should only do bug fixing in master. BUT at the same time, next branch isn't actually open until -rc2.
Up to you! It's not really urgent, Puma was migrated to TPL only in v2023.01 and we've lived without sysreset-gpio in TPL since then :)
Cheers, Quentin