
29 Jan
2009
29 Jan
'09
11:24 a.m.
Dear Ron Madrid,
In message 1233187331-20244-1-git-send-email-ron_madrid@sbcglobal.net you wrote:
This patch will exclude all functions from drivers/serial/ns16550.c from NAND_SPL builds with exception of NS16550_putc and NS16550_init. This will save space and remove unused code from already tightly constrained bootstrap images for NAND_SPL builds.
Signed-off-by: Ron Madrid ron_madrid@sbcglobal.net
drivers/serial/ns16550.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
This is a global file, so maybe we could use a less specific #define than CONFIG_NAND_SPL for this? Eventually we need this later to boot from device FOO, and I don't want to see this grow into
if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_FOO) && !defined(CONFIG_BAR) && ...
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
People with narrow minds usually have broad tongues.