On Sun, Jul 23, 2017 at 12:47 AM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Andy,
On Sun, Jul 23, 2017 at 12:38 AM, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Sat, Jul 22, 2017 at 3:59 PM, Bin Meng bmeng.cn@gmail.com wrote:
Hi Andy,
On Sat, Jul 22, 2017 at 3:32 AM, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
If ASL compiler failed by any reason do not produce output C file. Otherwise sequential run of make will shadow the actual error in ASL, i.e.
CC board/intel/edison/dsdt.o board/intel/edison/dsdt.c:1:1: error: unterminated comment /*
and user has to remove dsdt.c and run make in order to see the error again.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Thanks!
Although I am not sure how to reproduce "ASL compiler failed by any reason do not produce output C file"..
Add
Name (XXX) ({
Ah, I tried some pattern with no success but yours indeed triggers the issue.
line to dsdt.asl for Minnowboard MAX and you will see
ASL board/intel/minnowmax/dsdt.asl Compiler aborting due to parser-detected syntax error(s) board/intel/minnowmax/dsdt.asl.tmp 739: Name(XXX) ({ Error 6126 - ^ syntax error, unexpected PARSEOP_CLOSE_PAREN, expecting ','
Next run will get you above error (see commit message) which has been quite confusing.
P.S. Of course it's artificial, but better to handle iasl (potential) failures.
Thanks for the clarification! Tested-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!