On Tue, 9 Jan 2024 at 10:53, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:
table_compute_checksum() does neither changes the content of the checksummed buffer nor the buffer length. Adding const to the definition makes the function wider usable.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
v2: new patch
include/tables_csum.h | 2 +- lib/tables_csum.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/tables_csum.h b/include/tables_csum.h index 4812333093..9207e85f91 100644 --- a/include/tables_csum.h +++ b/include/tables_csum.h @@ -17,6 +17,6 @@
- @len: configuration table size
- @return: the 8-bit checksum
*/ -u8 table_compute_checksum(void *v, int len); +u8 table_compute_checksum(const void *v, const int len);
#endif diff --git a/lib/tables_csum.c b/lib/tables_csum.c index 636aa59676..305b1ec31c 100644 --- a/lib/tables_csum.c +++ b/lib/tables_csum.c @@ -5,9 +5,9 @@
#include <linux/types.h>
-u8 table_compute_checksum(void *v, int len) +u8 table_compute_checksum(const void *v, const int len) {
u8 *bytes = v;
const u8 *bytes = v; u8 checksum = 0; int i;-- 2.43.0
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org