On Mon, Aug 14, 2017 at 08:42:27PM -0400, Tom Rini wrote:
Now that sandbox is building cmd/mtdparts.c Coverity has looked at the code and found a number of issues. In index_partitions() it is possible that part will be NULL, so re-work the checks and debug statements to take this into account. We have a number of string buffers that we print to in the exact size of, and use string functions on, so we need to ensure they are large enough to be NULL terminated. In device_parse() it is not possible for num_partitions to be 0 (we would have hit a different error first) so remove logically dead code. Finally, in parse_mtdparts() if we have an error we need to free the memory allocated to dev.
Cc: Lothar Waßmann LW@KARO-electronics.de Cc: Maxime Ripard maxime.ripard@free-electrons.com Reported-by: Coverity (CID: 166334, 166333, 166332, 166329, 166328) Signed-off-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!