Hello Lubomir,
Am 04.06.2013 08:49, schrieb Lubomir Popov:
Hi Heiko,
On 04/06/13 07:26, Heiko Schocher wrote:
Hello Lubomir,
Am 03.06.2013 07:13, schrieb Heiko Schocher:
Hello Lubomir,
Am 02.06.2013 13:42, schrieb Lubomir Popov:
Hello Lubomir,
Am 01.06.2013 18:44, schrieb Lubomir Popov:
New i2c_read, i2c_write and i2c_probe functions, tested on OMAP4 (4430/60/70), OMAP5 (5430) and AM335X (3359); should work on older OMAPs and derivatives as well. The only anticipated exception would be the OMAP2420, which shall require driver modification.
[...]
drivers/i2c/omap24xx_i2c.c | 490 +++++++++++++++++++++++++++------------------ 1 file changed, 299 insertions(+), 191 deletions(-)
Tested on 3 arm335x based boards, which one uses i2c in SPL code for getting ram parameters, so:
Tested-by: Heiko Schocher hs@denx.de
Many thanks for testing, to Tom as well (he did it on the Beagleboards, but for one of the older versions, V3 I believe, right?). When it comes to versions, I see that V1 and V2 are still listed in patchwork, probably because of slightly different wording of the subject: http://patchwork.ozlabs.org/patch/233823/ http://patchwork.ozlabs.org/patch/246204/ Could you or Tom clean this up, please? Thanks.
Cleared the v3 v4 version, but missed the v2 and v1, Done.
just doing a "MAKEALL arm" with your patch applied and get this error:
Configuring for omap2420h4 board... omap24xx_i2c.c:497:17: error: 'struct i2c' has no member named 'irqstatus_raw' omap24xx_i2c.c:528:12: error: 'struct i2c' has no member named 'irqstatus_raw' arm-linux-gnueabi-size: './u-boot': No such file omap24xx_i2c.c: In function 'wait_for_bb': omap24xx_i2c.c:497:17: error: 'struct i2c' has no member named 'irqstatus_raw' omap24xx_i2c.c: In function 'wait_for_event': omap24xx_i2c.c:528:12: error: 'struct i2c' has no member named 'irqstatus_raw' make[1]: *** [omap24xx_i2c.o] Fehler 1 make: *** [drivers/i2c/libi2c.o] Fehler 2 make: *** Warte auf noch nicht beendete Prozesse...
Please fix this and run a "MAKEALL arm" before repost, thanks!
We have agreed upon this breakage with Tom - the OMAP2420 shall not be supported anymore in the next release. At least I understood it that way (and have noted it accordingly in the comments).
Ah, ok ... so affected boards should fixed too ...
@Tom: Could you than pick up this patch?
I could of course make a very simple modification that would allow build without errors, but the driver shall not work on the 2420; in order to make it work, a more serious rework is required. I don't have however any 2420 hardware to test upon.
Tom?
bye, Heiko