On Sunday, April 27, 2014 at 07:00:34 PM, Ian Campbell wrote:
On Sat, 2014-04-26 at 20:46 +0200, Marek Vasut wrote:
+#define ALIGN(x, a) __ALIGN_MASK((x), (typeof(x))(a)-1) +#define __ALIGN_MASK(x, mask) (((x)+(mask))&~(mask))
Isn't this already defined in include/common.h ?
Yes but it seems that header isn't usable by tools/* AFAICT. I get a boatload of compiler errors when I try...
There are a couple of things which include it even in tools/ :
# git grep common.h tools/ tools/patman/test.py: include/common.h | 8 ++++++ tools/patman/test.py:+#include <common.h> tools/scripts/define2mk.sed:# which preprocesses the common.h header files and outputs the final tools/updater/cmd_flash.c:#include <common.h> tools/updater/flash.c:#include <common.h> tools/updater/flash_hw.c:#include <common.h> tools/updater/update.c:#include <common.h> tools/updater/utils.c:#include <common.h>
btw. I should have escaped the dot in common.h pattern, but whatever ...
Best regards, Marek Vasut