Hi Macpaul,
On Wed, Feb 16, 2011 at 3:07 PM, Macpaul Lin macpaul@gmail.com wrote:
2011/2/16 Po-Yu Chuang ratbert.chuang@gmail.com
On Wed, Jan 26, 2011 at 5:19 AM, Wolfgang Denk wd@denx.de wrote:
Faraday's ftpmu010 is a power managemnet unit which support cpu
Ah, we are all waiting for the timer fix for arm then the related timer and pmu patch could be reorganized.
Do you mean there is another pmu patch to be reviewed?
Yes, I am waiting for the arm timer fix too, but I just want it at least to be able to compile.
Sorry for not following this thread. I notice this today because it breaks a320.
Could you please describe how does it breaks a320?
No big deal. Just because the original a320 timer code uses the register definitions like your new driver. Since the header is moved from arch/arm/include/asm/arch-a320/, it fails to compile (of course).
I think maybe it will be better to move driver/power/ftpmu010.h to include/ftpmu010.h and add the API declaration in it?
Does /* * PMU */ #define CONFIG_FTPMU010_POWER Couldn't help on fix the compile problem? Or if the problem occurs in runtime?
No, I already added that. What I need is the declaration of ftpmu010_32768osc_enable(). I want to use it to replace the original pmu register access code in timer_init().
Actually, I am done with the fix (move ftpmu010.h to include/ and add declarations). I can submit the patch. Just want to know if you think it is appropriate.
I am trying to fix arch/arm/cpu/arm920t/a320/timer.c, but I cannot access the new API now.
regards, Po-Yu Chuang