7 Jul
2010
7 Jul
'10
1:37 p.m.
-----Original Message----- From: Albert ARIBAUD [mailto:albert.aribaud@free.fr] Sent: Wednesday, July 07, 2010 4:54 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH V2 2/3] orion5x: add ide support for Marvell SATA
Le 07/07/2010 10:25, Prafulla Wadaskar a écrit :
+/* SControl register address */ +#define ORION5X_SATA_PORT1_SCONTROL_REG \
- (ORION5X_SATA_BASE+ORION5X_SATA_PORT1_OFFSET+0x308)
Please use c structure for register defination.
Hmm... There is a single register definition here -- I don't need more than this one. If I do a struct, it will only contain a single field. Still want this?
As per strategy and guidelines from Wolfgang- YES. we need it, I need to correct it for Kirkwood too
Regards.. Prafulla . .
Amicalement,
Albert.