On Tue, 19 Jul 2022 at 16:00, Douglas Anderson dianders@chromium.org wrote:
When you pass "--no-tree" to checkpatch it disables some extra checks that are important for Linux. Specifically I want checks like:
warning: DT compatible string "boogie,woogie" appears un-documented check ./Documentation/devicetree/bindings/
Let's make the default for Linux to _not_ pass --no-tree. We'll have a config option and command line flag to override.
Signed-off-by: Douglas Anderson dianders@chromium.org
Without BooleanOptionalAction (python 3.9), it's a little odd to make the help text understandable while having the help text account for the project settings when printing the default (which it can only print as "True" or "False". It feels like no matter how you swing it you've got to use a double-negative or use weird syntax like I did.
I removed previous review/testing tags since at least parts of this patch changed in non-trivial ways.
This patch is now a singleton since the other patches in the series landed or became irrelevant.
Changes in v4:
- Don't use BooleanOptionalAction
tools/patman/checkpatch.py | 11 +++++++---- tools/patman/control.py | 7 ++++--- tools/patman/main.py | 6 ++++++ tools/patman/settings.py | 3 ++- 4 files changed, 19 insertions(+), 8 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm, thanks!