On Tue, Feb 26, 2013 at 3:47 PM, Benoît Thébaudeau benoit.thebaudeau@advansee.com wrote:
That's correct.
is_16bit_nand() is only used to conditionally set NAND_BUSWIDTH_16 in this->options, then this flag is tested everywhere else, so we could also completely drop is_16bit_nand() and just do: #ifdef CONFIG_SYS_NAND_BUSWIDTH_16BIT this->options |= NAND_BUSWIDTH_16; #endif
Yes, this could be done.
What do you think is better? I'm fine with your implementation.
My main goal with this patch series was to fix a bug, and I think I can do as you suggest, and get rid of is_16bit_nand() in a future patch.
Should I rebase my series on that, keeping both series separate, or should I integrate these 2 patches as is at the beginning of my series?
I would say that you could send this series as is at the beginning of your next version in order to avoid conflicts.
Thanks,
Fabio Estevam