19 Jul
2009
19 Jul
'09
7:17 p.m.
Dear Alessandro Rubini,
In message 20090719151345.GA17567@mail.gnudd.com you wrote:
From: Alessandro Rubini rubini@gnudd.com
Since env_addr is a loff_t (long long), "%08lx" is not a good format; this uses "%08llx" (not "%016llx"), to get 8 or more hex digits. I tnknk padding to 8 digits makes things more readable for "small" numbers, and the unlikely values over 4GB are reported correctly anyways.
But %llx needs CONFIG_SYS_64BIT_VSPRINTF - are we sure that this is #define'd on all boards that use onenand?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"In the face of entropy and nothingness, you kind of have to pretend
it's not there if you want to keep writing good code."
- Karl Lehenbauer