On Wed, Jan 23, 2019 at 07:19:30PM +0530, Vignesh R wrote:
On 23/01/19 12:26 AM, Tom Rini wrote:
On Tue, Jan 22, 2019 at 08:33:54PM +0530, Vignesh R wrote:
From: Grygorii Strashko grygorii.strashko@ti.com
Texas Instruments' System Control Interface (TI-SCI) Message Protocol abstracts management of NAVSS resources, like PSI-L pairing and unpairing, UDMAP tx/rx/flow configuration and Rings.
This patch adds support for requesting and configuring such resources from TI-SCI firmware.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com Signed-off-by: Grygorii Strashko grygorii.strashko@ti.com
Reviewed-by: Tom Rini trini@konsulko.com
But:
+/**
- Configures a Navigator Subsystem UDMAP transmit channel
- Configures a Navigator Subsystem UDMAP transmit channel registers.
- See @ti_sci_msg_rm_udmap_tx_ch_cfg_req
- */
+struct ti_sci_msg_rm_udmap_tx_ch_cfg {
- u32 valid_params;
+#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FILT_EINFO_VALID BIT(9) +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FILT_PSWORDS_VALID BIT(10) +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_SUPR_TDPKT_VALID BIT(11) +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_CREDIT_COUNT_VALID BIT(12) +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FDEPTH_VALID BIT(13)
This and similar instances are some pretty odd style. Rework to be the defines then the struct?
Its pretty common style (at least in kernel code) to #define constants just below a struct member to indicate that these flags apply only to that member. I can rework if you feel otherwise.
Really? Alright, leave it I guess then, thanks.