On Thu, 2015-04-16 at 09:35 +0200, Hans de Goede wrote:
Hi,
On 15-04-15 22:00, Ian Campbell wrote:
On Tue, 2015-04-14 at 18:06 +0200, Hans de Goede wrote:
From: Vishnu Patekar vishnupatekar0510@gmail.com
A quick comment on what "basic" here means, i.e. "prcm, rsb, clocks as per sun6i", etc would be good.
Actually the Basic is misleading here, since this adds full support, usb controller, display output, etc. everything works, so I'll drop the Basic from the Subject and add a proper commit message.
Signed-off-by: Vishnu Patekar vishnupatekar0510@gmail.com Signed-off-by: Hans de Goede hdegoede@redhat.com
Did you make non-trivial mods or is this S-o-b just a passing it along one? (In the latter case I won't bother to review deeply myself unless you want me to)
I made non-trivial mods, both the display driver and usb driver changes are all from my hand.
@@ -103,6 +107,10 @@ static void usb_phy_write(struct sunxi_usbc_hcd *sunxi_usbc, int addr, int j = 0, usbc_bit = 0; void *dest = sunxi_usbc_get_io_base(0) + SUNXI_USB_CSR;
+#ifdef CONFIG_MACH_SUN8I_A33
- writel(0, dest);
+#endif
Some undocumented/commented magic?
Pretty much, I took this from the Allwinner sources which have a comment along the lines of this needs to be explicitly initialized to 0 on A33, I can add such a comment if you want me to.
I think a comment would be good, lest someone in the future think it was put there for as known reason.
Ian.