
2009/5/12 Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com:
On 21:03 Mon 11 May , Magnus Lilja wrote:
2009/5/10 Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com:
- }
- page_count = CFG_NAND_CHIP_SIZE / CFG_NAND_PAGE_SIZE;
please use CONFIG_SYS_ or CONFIG_
Will do.
and why not detect it?
Might be possible, I'll look into it to see if it's doable.
tks
It's not really doable. In order for this to be worthwhile the nand_flash_ids array from drivers/mtd/nand/nand_ids.c would have to fit into the available space (2048 byte in total) and it didn't even though I removed the text-strings.
as you mention here there is only 2K so the start.S was reduced to allow more code so CONFIG_xxx_IPL/SPL do not describe this so please chance it to a better one
As I said in another email: "The main purpose of CONFIG_ONENAND_IPL and NAND_SPL in start.S is to change the behaviour a bit, not so much to save some space." Given that those CONFIG_s are used in other places as well to indicate the type of boot I don't think it's good to create a new CONFIG_ that one has to specify in addition to one of the above.
Regards, Magnus
Best Regards, J.