Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:35 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 15:47 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 12:46 Sat 08 Aug , Dirk Behme wrote: > Since there is only one version of flushing the dcache for > arm_cortex8, rename v7_flush_dcache_all to the the generic > name flush_dcache. Because the function is intended for > only omap3 boards, move the function to the new file > cache_flush.S. > > Signed-off-by: Tom Rix Tom.Rix@windriver.com > Signed-off-by: Dirk Behme dirk.behme@googlemail.com > --- NACK keep the arm arch version in the name
NACK the NACK, see below.
and as request to Tom remove the non need device_type and we can safely use the v7 cache flush for omap3 and other cortex a8
This can be done easily (later?) by an additional patch (when people have time for it?).
Applying the basic functionality (function move) now allows others to finally go on with their long waiting patches.
no this code is omap3 specific and there is no need ot this rename or move the function make no sense
Yes, it is OMAP3 specific (as already mentioned in the patch description). So it's totally fine to move it to an OMAP3 specific file. So it's totally fine that others (!= OMAP3, e.g Samsung) can re-use arm_cortexa8 stuff without the burden of OMAP3 stuff.
the flush MUST NOT be soc specific as there is NO need to do this at all
so NACK
Let's summarize:
- First, you NACK because of device_type and function name
- Then, you mention "this code is omap3 specific"
- Then, you mention "this code is not needed at all"
Sorry, but this sounds somehow confusing, better let us stop here.
As already mentioned, let us apply the patch so that other Cortex A8 patches are not stalled any more.
At the weekend, I missed the point why this code is OMAP3 specific and why it has to be moved to omap3 directory, so short update:
It calls OMAP3 ROM code. This doesn't work on other Cortex A8, e.g. Samsung. That is, it must be moved to not stall others any more.
(Thanks to Tom for remembering this!)
Best regards
Dirk