Missed the v2 (and wasn't subscribed to the U-Boot list), so the comments are mostly repeated.
On 12/30/2017 06:47 AM, Adam Ford wrote:
This converts the following to Kconfig: CONFIG_SOC_DA8XX CONFIG_SOC_DA850 CONFIG_MACH_DAVINCI_DA850_EVM
Signed-off-by: Adam Ford aford173@gmail.com
README | 2 -- arch/arm/mach-davinci/Kconfig | 24 +++++++++++++++++++++--- include/configs/calimain.h | 2 -- include/configs/da850evm.h | 3 --- include/configs/ea20.h | 3 --- include/configs/ipam390.h | 3 --- include/configs/legoev3.h | 3 --- include/configs/omapl138_lcdk.h | 1 - scripts/config_whitelist.txt | 3 --- 9 files changed, 21 insertions(+), 23 deletions(-)
diff --git a/README b/README index 06f3ed0..ea7923e 100644 --- a/README +++ b/README @@ -2351,8 +2351,6 @@ The following options need to be configured:
CONFIG_AT91SAM9XE enable special bootcounter support on at91sam9xe based boards.
CONFIG_SOC_DA8XXenable special bootcounter support on da850 based boards.
Probably better to add a new config option CONFIG_BOOTCOUNT_DA8XX.
CONFIG_BOOTCOUNT_RAM enable support for the bootcounter in RAM CONFIG_BOOTCOUNT_I2Cdiff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index 35e4e9b..7b6f10d 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -6,33 +6,41 @@ choice
config TARGET_IPAM390 bool "IPAM390 board"
- select MACH_DAVINCI_DA850_EVM
- select SOC_DA850 > select SUPPORT_SPL
- select SYS_DA850_PLL_INIT
- select SYS_DA850_DDR_INIT
Trailing whitespace
config TARGET_DA850EVM bool "DA850 EVM board"
select MACH_DAVINCI_DA850_EVM
select SOC_DA850 select SUPPORT_SPL select SYS_DA850_PLL_INIT select SYS_DA850_DDR_INIT
config TARGET_EA20 bool "EA20 board"
select MACH_DAVINCI_DA850_EVM
select SOC_DA850 select BOARD_LATE_INIT
config TARGET_OMAPL138_LCDK bool "OMAPL138 LCDK"
select SOC_DA850 select SUPPORT_SPL select SYS_DA850_PLL_INIT select SYS_DA850_DDR_INIT
config TARGET_CALIMAIN bool "Calimain board"
select SOC_DA850 select SYS_DA850_PLL_INIT select SYS_DA850_DDR_INIT
config TARGET_LEGOEV3 bool "LEGO MINDSTORMS EV3"
select MACH_DAVINCI_DA850_EVM
select SOC_DA850 select SYS_DA850_PLL_INIT select SYS_DA850_DDR_INIT
Since you cleaned this up in TARGET_IPAM390, you could clean up other boards too. CONFIG_SYS_DA850_PLL_INIT and CONFIG_SYS_DA850_DDR_INIT don't do anything if CONFIG_DA850_LOWLEVEL is not defined, so they can be removed from all boards except TARGET_CALIMAIN and TARGET_DA850EVM.
If CONFIG_DA850_LOWLEVEL was also made into a Kconfig option, then
select SYS_DA850_PLL_INIT if DA850_LOWLEVEL select SYS_DA850_DDR_INIT if DA850_LOWLEVEL
would actually be more correct.