On Tue, Mar 17, 2020 at 10:29:42AM -0600, Simon Glass wrote:
Hi Tom,
On Mon, 16 Mar 2020 at 15:16, Tom Rini trini@konsulko.com wrote:
On Sun, Mar 15, 2020 at 05:42:54PM -0600, Simon Glass wrote:
This is not needed in the test.py part of the config, now since we use the same name as the pytests.
Drop BUILDMAN, retaining it only for the 'build' parts of the config, i.e. where we build multiple boards and don't run any tests.
Signed-off-by: Simon Glass sjg@chromium.org
[snip]
diff --git a/.travis.yml b/.travis.yml index 3149ed6a15..42a3923565 100644 --- a/.travis.yml +++ b/.travis.yml @@ -119,7 +119,7 @@ script: # From buildman, exit code 129 means warnings only. If we've been asked to # use clang only do one configuration. # Build a selection of boards if TEST_PY_BD is empty
- if [[ "${BUILDMAN}" != "" ]] && [[ "${TEST_PY_BD}" == "" ]]; then
- if [[ "${BUILDMAN}" != "" ]]; then ret=0; tools/buildman/buildman -P -E ${BUILDMAN} ${OVERRIDE}|| ret=$?; if [[ $ret -ne 0 && $ret -ne 129 ]]; then
This looks wrong. We don't set BUILDMAN anymore anywhere, right? So shouldn't this just be the test for TEST_PY_BD is empty? Thanks!
BUILDMAN is still set for the non-test builds, i.e. when we build a lot of boards and don't run any tests.
It is empty of the test build, but still used.
Ah, OK, thanks.