Re: [PATCH v2 5/6] image: Drop if/elseif hash selection in calculate_hash()

On Thu, Sep 02, 2021 at 07:54:21PM -0500, Alexandru Gagniuc wrote:

calculate_hash() would try to select the appropriate hashing function by a if/elseif contruct. But that is exactly why hash_lookup_algo() exists, so use it instead.

This does mean that we now have to 'select HASH' to make sure we get the hash_lookup_algo() symbol. However, the change makes sense because even basic FITs will have to deal with "hash" nodes.

My only concern is that the 'select SPL_HASH' might cause some platform to grow above its SPL size allowance

Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com

Applied to u-boot/master, thanks!