Simon,
Nothing critical and this could go in as-is, but a few nits below.
On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass sjg@chromium.org wrote:
raw += LookupEmail(item, alias)
raw += LookupEmail(item, alias, raise_on_error=not ignore_errors)
optional: Change it so functions are consistent about whether it's "raise_on_error" or "ignore_errors"
False, alias)
Doctest that actually tests the raise_on_error? See doctests in gitutil.py for example syntax.
-def LookupEmail(lookup_name, alias=None, level=0): +def LookupEmail(lookup_name, alias=None, raise_on_error=True, level=0): """If an email address is an alias, look it up and return the full name
TODO: Why not just use git's own alias feature? Args: lookup_name: Alias or email address to look up
alias: Dictionary containing aliases (None to use settings default)raise_on_error: True to raise an error when an alias fails to match
...and what happens if you pass False?
- \033[1;31mAlias 'odd' not found\033[0m
- []
- \033[1;31mRecursive email alias at 'other'\033[0m
- \033[1;31mRecursive email alias at 'john'\033[0m
- \033[1;31mRecursive email alias at 'mary'\033[0m
- ['j.bloggs@napier.co.nz', 'm.poppins@cloud.net']
optional nit: for optional args it's nice to specify them with keywords, like
LookupEmail('loop', alias=alias, raise_on_error=False)
Please test the raise_on_error=True case.
-Doug