Re: [U-Boot] [PATCH] rsa: Fix two errors in the implementation

Hello Simon,

...

{

• uint32_t i;

• int i;
  • for (i = key->len - 1; i >= 0; i--) {
• for (i = (int)key->len - 1; i >= 0; i--) { if (num[i] < key->modulus[i]) return 0; if (num[i] > key->modulus[i])

I did indeed not post a patch, since I do not know how this code is used and how critical it is. And I still haven't bothered to look it up.

So just a general comment, which might not make any sense at all for the actual usage. If num can somehow be controlled by an

I meant key->len here of course ^

Regards, Jeroen