Re: [PATCH] drivers: rtc: fix null pointer access in armada38x_rtc_reset

On 2/28/22 10:31, fberder@outlook.fr wrote:

From: Francois Berder fberder@outlook.fr

Replace null pointer by pointer to device registers when calling armada38x_rtc_write.

Signed-off-by: Francois Berder fberder@outlook.fr

Applied to u-boot-marvell/master

Thanks, Stefan

---

drivers/rtc/armada38x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/armada38x.c b/drivers/rtc/armada38x.c index 2d264acf77..2af64e3912 100644 --- a/drivers/rtc/armada38x.c +++ b/drivers/rtc/armada38x.c @@ -121,7 +121,7 @@ static int armada38x_rtc_reset(struct udevice *dev) armada38x_rtc_write(0, rtc, RTC_CONF_TEST); mdelay(500); armada38x_rtc_write(0, rtc, RTC_TIME);

• armada38x_rtc_write(BIT(0) | BIT(1), 0, RTC_STATUS);
  

• armada38x_rtc_write(BIT(0) | BIT(1), rtc, RTC_STATUS);
  

  }

  return 0;

Viele Grüße, Stefan Roese