
Le 13/04/2011 23:05, Mike Frysinger a écrit :
On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
Le 13/04/2011 05:48, Mike Frysinger a écrit :
if (strchr(dev->name, ' '))
puts("\nWarning: eth device name has a space!\n");
puts("\nWarning: eth device name has a "
"space!\n");
please dont change unrelated things. that newline should be there, and this string shouldnt be broken up.
Technically it is not. A C string constant can be made of several quote-delimited string literals separated by whitespace -- so this change is a no-op, and does not remove any newline btw. I suspect the change is to keep checkpatch.pl happy about the line length.
you truncated my quote which changes things significantly. i wasnt talking about the string when i said newline. -mike
Sorry about that -- I did truncate indeed, to keep your comment and the change that was immediately before it, which I thought the comment was referring to exclusively.
Amicalement,