26 Jul
2019
26 Jul
'19
9:49 p.m.
On Wed, 17 Jul 2019 19:35:52 +0000 Niklas Schulze me@jns.io wrote: ...
@@ -812,6 +813,15 @@ static int hdmi_read_edid(struct dw_hdmi *hdmi, int block, u8 *buff) u32 trytime = 5; u32 n;
- struct udevice *chip;
- if (hdmi->ddc_bus) {
here, please use something like:
if (CONFIG_IS_ENABLED(DM_I2C) && hdmi->ddc_bus) { struct udevice *chip;
there are boards that do not enable CONFIG_DM_I2C yet, and we will see build breakage in such cases:
drivers/built-in.o: In function `hdmi_read_edid': drivers/video/meson/../dw_hdmi.c:818: undefined reference to `i2c_get_chip' drivers/video/meson/../dw_hdmi.c:822: undefined reference to `dm_i2c_read'
-- Anatolij