Re: [PATCH v3] i2c: rcar_i2c: Fix i2c read/write errors

Hello Lad,

Am 30.09.2020 um 14:24 schrieb Lad Prabhakar:

commit 7c8f821e ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer") blindly called rcar_i2c_set_addr() with read argument always set to 1 during xfer which introduced read/write errors, whereas earlier rcar_i2c_read_common() called rcar_i2c_set_addr() with read set to 1 and rcar_i2c_write_common() called rcar_i2c_set_addr() with read set 0.

Fixes: 7c8f821e ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer") Signed-off-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com

---

v2->v3

• Made sure value of read is ether 0/1 as pointed by Marek

v1->v2

• Incorporated suggestion from Heiko

v1: https://patchwork.ozlabs.org/project/uboot/patch/ 20200921163353.5540-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Thanks!

Reviewed-by: Heiko Schocher hs@denx.de

bye, Heiko