Hello.
Po-Yu Chuang wrote:
From: Po-Yu Chuang ratbert@faraday-tech.com
This patch also update get_timer() usage.
This seems like a material for a separate patch.
Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com
drivers/net/ftmac100.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ftmac100.c b/drivers/net/ftmac100.c index 2328cb5..787d69b 100644 --- a/drivers/net/ftmac100.c +++ b/drivers/net/ftmac100.c
[...]
@@ -219,14 +219,12 @@ ftmac100_send (struct eth_device *dev, volatile void *packet, int length) curr_des->txdes0 = FTMAC100_TXDES0_TXDMA_OWN;
/* start transmit */
writel (1, &ftmac100->txpd);
/* wait for transfer to succeed */
tmo = get_timer (0) + 5 * CONFIG_SYS_HZ;
- start = get_timer (0); while (curr_des->txdes0 & FTMAC100_TXDES0_TXDMA_OWN) {
if (get_timer (0) >= tmo) {
if (get_timer (start) >= 5) {
I'm not sure this is equivalent to the old code...
debug ("%s(): timed out\n", __func__); return -1; }
checkpatch.pl says:
WARNING: space prohibited between function name and open parenthesis '(' #66: FILE: drivers/net/ftmac100.c:225: + start = get_timer (0);
WARNING: space prohibited between function name and open parenthesis '(' #69: FILE: drivers/net/ftmac100.c:227: + if (get_timer (start) >= 5) {
I know you're only modifying the existing code, but it's time to fix the style of it as well...
WBR, Sergei