Re: [PATCH 1/1] cli: always show cursor

Hi Heinrich,

On Sat, 22 Oct 2022 at 03:21, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:

We may enter the command line interface in a state where on the remote console the cursor is not shown. Send an escape sequence to enable it.

Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com

common/main.c | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/common/main.c b/common/main.c index 682f3359ea..4e7e7b17d6 100644 --- a/common/main.c +++ b/common/main.c @@ -7,6 +7,7 @@ /* #define DEBUG */

#include <common.h> +#include <ansi.h> #include <autoboot.h> #include <bootstage.h> #include <cli.h> @@ -66,6 +67,9 @@ void main_loop(void)

    autoboot_command(s);

•   if (!CONFIG_IS_ENABLED(DM_VIDEO) || CONFIG_IS_ENABLED(VIDEO_ANSI))
  

•           printf(ANSI_CURSOR_SHOW "\n");
  

Could we create a library which emits these codes? Like ansi_cursor_show() ?

•   cli_loop();
    panic("No CLI available");
  

}

2.37.2

Regards, Simon