Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

On Tue, Jan 30, 2024 at 02:04:51PM +0000, Caleb Connolly wrote:

• /* The clock is already enabled by the clk_bulk above */
• ret = clk_set_rate(&prv->clks.clks[i], clk_rate);
• if (!ret) {

• printf("Couldn't set core clock rate: %d\n", ret);
  

• return -EINVAL;
  

The if statement looks reversed. Or if we want clk_set_rate() to fail then there isn't a reason to print "ret" in the error message because we know that's zero.

• }

  return 0;

}

regards, dan carpenter