On Wed, 19 Aug 2009 09:55:46 -0700 Ben Warren biggerbadderben@gmail.com wrote:
My preference is for the drivers to handle alignment.
OK, I'm fine with that. I'd like to withdraw this patch then.
I like Dave's idea of creating a buffer (or multiple buffers) in initialization(), then memcpy'ing to to it in the send() routine. You could make it smart to only memcpy if the frame is not aligned as needed.
It already only memcpys unaligned buffers, but I'll go with Daves suggestion and allocate it at startup instead.
Your original patch created a buffer of size 9000, which I commented was probably bigger than necessary. I didn't see a response to that (which doesn't mean you didn't send one, but I get a lot of e-mail :)
I was off for vacation [*], so I only sent it this week. I'll rework this patch a bit to address a small bug I found.
Thanks for the comments! // Simon [*] By now the U-boot list is probably tired of hearing about my vacation, but I can assure you that I had a good time!