On 9/9/21 10:57 AM, Simon Glass wrote:
Hi Heinrich,
On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 9/8/21 3:33 PM, Simon Glass wrote:
This code should never have been added as it builds a new feature on top of legacy code. Drop it and add a dependency on BLK for this feature.
Boards which want EFI_LOADER should migrate to driver model first.
Signed-off-by: Simon Glass sjg@chromium.org
This patch is not related to the rest of the series and the code has a different maintainer.
So, please, separate it from the series.
Who is the maintainer?
Until 623b3a57976 ("efi_selftest: provide an EFI selftest application") there was no official maintainer for lib/efi/ but you were the main contributor.
But with that patch directory lib/efi/ was assigned to EFI PAYLOAD.
I am happy if you would continue to care about U-Boot on EFI.
I need this patch for this series to work. You can still review things for other maintainers and in this case it is common for one maintainer to pick up the series once the others are happy.
The direction of this patch is completely correct.
There are some things that will have to be changed, e.g we should not require CONFIG_DM_ETH=y. I will work on reviewing this patch in detail.
I already added CONFIG_BLK as a requirement for CONFIG_EFI_LOADER in a submitted patch.
Removing legacy code from lib/efi_loader/efi_disk.c and lib/efi_loader/efi_device_path.c could be done before all U-Boot on EFI patches.
Therefore I still think it makes sense to split the series in two:
1) Cleanup of the UEFI implementation 2) Rework of U-Boot on EFI
I hope merging in this sequence of patch series makes send to you.
Best regards
Heinrich