Re: [U-Boot-Users] PATCH: save 'ver' env var on update

In message 5CBE65F7D9232C47861CB09B0954861C66A986@MAIL.infinitychannel.local you wrote:

diff --git a/common/main.c b/common/main.c index 379695c..429d367 100644 --- a/common/main.c +++ b/common/main.c @@ -326,10 +326,11 @@ void main_loop (void) #endif /* CONFIG_MODEM_SUPPORT */

#ifdef CONFIG_VERSION_VARIABLE

•   extern char version_string[];
  

•   if (strcmp(getenv("ver"), version_string))
    {
  

•           extern char version_string[];
  

•           setenv ("ver", version_string);  /* set version variable
  

*/

•           run_command("saveenv", 0);
    }
  

#endif /* CONFIG_VERSION_VARIABLE */

As mentioned before, I reject this patch.

U-Boot is not supposed to do such things like writing to the flash "automagically".

If you need this function, please implement it as a script.

[And BTW: is there a special reason why you did not call do_saveenv() directly?]

Best regards,

Wolfgang Denk