Re: [PATCH] dm: core: Correct comment on uclass_id_foreach_dev()

On Sun, Jun 14, 2020 at 4:49 PM Simon Glass sjg@chromium.org wrote:

This parameter should be a struct uclass, not struct udevice. Correct it.

Signed-off-by: Simon Glass sjg@chromium.org

include/dm/uclass.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/dm/uclass.h b/include/dm/uclass.h index 70fca79b44..67ff7466c8 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -390,7 +390,7 @@ int uclass_resolve_seq(struct udevice *dev);

• @id: enum uclass_id ID to use
• @pos: struct udevice * to hold the current device. Set to NULL when there
• are no more devices.

• • @uc: temporary uclass variable (struct udevice *)

• • @uc: temporary uclass variable (struct uclass *)
  */

#define uclass_id_foreach_dev(id, pos, uc) \ if (!uclass_get(id, &uc)) \ -- 2.27.0.290.gba653c62da-goog

Reviewed-By: Michael Trimarchi michael@amarulasolutions.com