Subject: Re: [U-Boot] [PATCH 1/2] mmc: omap3: make local symbols static
On Sun, Aug 8, 2010 at 12:43 PM, Wolfgang Denk wd@denx.de wrote:
Dear Andy,
In message 1276722323-12045-1-git-send-email-notasas@gmail.com
Grazvydas Ignotas wrote:
Make driver local variables and functions static and remove them from the arch header.
Signed-off-by: Grazvydas Ignotas notasas@gmail.com
arch/arm/include/asm/arch-omap3/mmc.h | 9 --------- drivers/mmc/omap3_mmc.c | 33 +++++++++++++++++--------
2 files changed, 17 insertions(+), 25 deletions(-)
I haven't seen commants for these two patches:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/79999
I tested these two patches today on Beagle (OMAP3) and Panda (OMAP4).
I was able to boot linux and rootfs images from MMC on both machines, so:
Acked-by: Steve Sakoman steve@sakoman.com Tested-by: Steve Sakoman steve@sakoman.com
Unfortunately the patches didn't apply cleanly, but the fixes were simple. I have the modified patches in the omap4-next-upstream branch of my repo for convenience:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u- boot.git;a=shortlog;h=refs/heads/omap4-next-upstream
Regards,
Steve
I have added to u-boot-ti master.
The e-mail address in the signed-off-by was incorrect. I believe using "at" is not allowed.
I manually edited. I'll send a pull request to Wolfgang.
Its upto him to accept these mmc related patches.
Regards, Sandeep