
12 Nov
2007
12 Nov
'07
4 p.m.
Matthias Fuchs wrote:
Hi Jerry,
On Monday 12 November 2007 14:24, Jerry Van Baren wrote:
- char val;
- unsigned char val;
Trivia: This change should not be necessary since you fixed the conditional (below) to do a bit-wise & 0x80 rather than a signed compare that has portability and aesthetic problems.
yes, of course.
val = data [bytecount ++];
But since the right value is an unsigned char, I like the left value to be of the same type.
Painting the bike shed blue,
We should ask the others that are involved ins discussion if blue might bring disadvantages :-)
Matthias
Oops, yes, you are right. My jaundiced eye read *signed* char instead of unsigned.
Sorry for the noise, gvb
(feeling blue...)