On 31 August 2015 at 08:38, Joe Hershberger joe.hershberger@gmail.com wrote:
Hi Simon,
On Sun, Aug 30, 2015 at 5:45 PM, Simon Glass sjg@chromium.org wrote:
Hi,
On 27 August 2015 at 23:25, Bin Meng bmeng.cn@gmail.com wrote:
Commit 620776d "tftp: adjust settings to be suitable for 100Mbit ethernet" causes the following error message when trying to load a file using 'tftp' command via a tftp server.
TFTP error: 'Unsupported option(s) requested' (8)This is due to with commit 620776d changes, the tftp option 'timeout' value is now set to zero which is an invalid value as per RFC2349 [1]. Valid values range between "1" and "255" seconds, inclusive. With some tftp servers that strictly implement the RFC requirement, it reports such an error message.
Revert commit 620776d for RFC compliance.
[1] https://www.ietf.org/rfc/rfc2349.txt
Signed-off-by: Bin Meng bmeng.cn@gmail.com Acked-by: Joe Hershberger joe.hershberger@ni.com
Changes in v3:
- Drop e1000 build warning patch which is already applied
Changes in v2:
- Rewrite the commit message to mention RFC2349
This series is assigned to me in patchwork. Since the series seems to consist of bug fixes and driver model conversion of a driver with no other users, I'm inclined to apply it now.
Please let me know if you disagree.
I'm fine with that.
-Joe
Applied to u-boot-x86, thanks!