On 03/30/2015 08:08 PM, Joe Hershberger wrote:
Hi Michal,
On Tue, Mar 24, 2015 at 2:41 AM, Joe Hershberger joe.hershberger@ni.com wrote:
When the ethaddr changes in the env, the hardware should also be updated so that MAC filtering will work properly without resetting U-Boot.
Also remove the manual calls to set the hwaddr that was included in a few drivers as a result of the framework not doing it.
Reported-by: Michal Simek michal.simek@xilinx.com Signed-off-by: Joe Hershberger joe.hershberger@ni.com
Changes in v2: -Implement the check in non-DM eth_initialize also -Use static helper function in DM case
drivers/net/bcm-sf2-eth.c | 6 ---- drivers/net/designware.c | 4 --- drivers/net/macb.c | 9 ------ net/eth.c | 76
++++++++++++++++++++++++++++++-----------------
4 files changed, 48 insertions(+), 47 deletions(-)
Does this sufficiently resolve the issue you have?
I wouldn't say it was my issue. It was more about asking what's the right thing to do. But anyway I have tested it with our ethernet driver and it is working fine.
I have applied it on the top of u-boot-dm/next.
Tested-by: Michal Simek michal.simek@xilinx.com
Thanks, Michal