Re: [U-Boot] [PATCH 1/2] cmd_i2c: rename EDO, DDR and SDRAM to avoid conflict with at91 memory setup

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1229469026-7344-1-git-send-email-plagnioj@jcrosoft.com you wrote:

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com Cc: Timo Tuunainen timo.tuunainen@sysart.fi

---

common/cmd_i2c.c | 58 +++++++++++++++++++++++++++--------------------------- 1 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index 448f2fe..a662b53 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -712,7 +712,7 @@ static void decode_bits (u_char const b, char const *str[], int const do_once) */ int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) {

• enum { unknown, EDO, SDRAM, DDR2 } type;

• enum { unknown, _EDO, _SDRAM, _DDR2 } type;

Please do not use leading underscores in regular variable names. They are reserved in C.

Best regards,

Wolfgang Denk